search

RustCrypto / hashes

Collection of cryptographic hash functions written in pure Rust
1.82k stars 247 forks source link

Fix `KeyInit` for blake2 #432

Closed vlad9486 closed 1 year ago

vlad9486 commented 1 year ago

Right now it is crashes always on KeyInit::new.

newpavlov commented 1 year ago

Your changes are incorrect, you try to pass key as salt. How exactly does it crash?

vlad9486 commented 1 year ago

@newpavlov Please, look again. The original code is incorrect and passing key as salt. My fix is fixing that. Here is the test, which is crashed #433.

newpavlov commented 1 year ago

Oh... True. We have tests for the MAC types, but they different codepath.