search

RustCrypto / hashes

Collection of cryptographic hash functions written in pure Rust
1.81k stars 245 forks source link

Fix SHA3 performance degradation #472

Closed aewag closed 1 year ago

aewag commented 1 year ago

Related issue #468

@Slixe Could you please give this branchof the SHA3 crate a try and see if it fixes the performance degradation?

If it does, I would finalize it and mark it as ready.

Slixe commented 1 year ago

LGTM.

v1.0.6: ~ 10 MH/s

v1.0.7 (bug introduced): ~ 4 MH/s

This pull request seems to fix it because I'm at ~ 10 MH/s with it again.

Thanks for your work :slightly_smiling_face:

tarcieri commented 1 year ago

@aewag if you can remove WIP/draft we can get this merged

aewag commented 1 year ago

@aewag if you can remove WIP/draft we can get this merged

will do. just one question: shall the sha3 crate take the keccak from git or do you plan to release a patch?

tarcieri commented 1 year ago

@aewag keccak v0.1.4 has been released

aewag commented 1 year ago

@tarcieri nice, just updated the PR and flagged it as ready