RustCrypto / hashes

Collection of cryptographic hash functions written in pure Rust
1.76k stars 239 forks source link

`sha2` fails to build in Windows on an ARM device #502

Closed jdjaustin closed 10 months ago

jdjaustin commented 10 months ago

sha2 fails to build in Windows on an ARM device. Removing asm = ["sha2-asm"] from sha2/Cargo.toml allows the crate to build.

tarcieri commented 10 months ago

The asm feature is unsupported on MSVC, which is my guess as to what is happening: https://github.com/RustCrypto/asm-hashes/issues/17

We need to migrate to inline ASM, which will fix all of these platform-specific concerns.

newpavlov commented 10 months ago

You should find which crate in your dependency tree enables the asm feature. We explicitly state that this feature SHOULD NOT be enabled by library crates. The lack of Windows support is a known problem and tracked in the linked asm-hashes issue, so I think we can close this issue in favor of it.