search

RustCrypto / key-wraps

Symmetric key-wrapping algorithms
10 stars 6 forks source link

Implement AES-KW #1

Closed cryptographix closed 2 years ago

cryptographix commented 2 years ago

Initial submission based on @dignifiedquire's code minimally modified for RustCrypto repo.

cryptographix commented 2 years ago

@tarcieri, I have included .github CI directory copied from KDFs, but it is not running. Got a missing 'workflow' scope during push. Can you or @newpavlov sort it out?

tarcieri commented 2 years ago

Hmm, not super wild about the implementation being a giant macro, and the whole thing doesn't look no_std-friendly.

I can do a cleanup pass after we get some initial code merged and passing CI.

dignifiedquire commented 2 years ago

@tarcieri should be easy to get rid of the macro if we can use const generics. There is some other stuff in there I want to improve myself, I can probably PR sth later today.

cryptographix commented 2 years ago

@tarcieri, @dignifiedquire please feel free to do a cleanup.

tarcieri commented 2 years ago

I'd suggest renaming the aes_kw directory to aes-kw to match the crate name.

Not sure why CI isn't running but it's possible we need to merge the initial config first.

tarcieri commented 2 years ago

Cool, seems like a start.

Going to merge this and we can see if that's enough to kick off CI.

tarcieri commented 2 years ago

That worked. CI is now running (and failing):

https://github.com/RustCrypto/key-wraps/actions/runs/1659124665

Looks like it also needs rustfmt.

cryptographix commented 2 years ago

@tarcieri I'm a bit out of my depth with the CI stuff. Can you point me in the right direction? I remember seeing other targets are failing due to not yet being no-std.

tarcieri commented 2 years ago

I can take a look, yeah