RustCrypto / password-hashes

Password hashing functions / KDFs
677 stars 84 forks source link

argon2: add benchmarks using criterion #437

Closed dyc3 closed 1 year ago

dyc3 commented 1 year ago

I added some benchmarks using the criterion crate. The reason I chose to include criterion is because it makes it easier to determine if a change has a statistically significant impact.

I'm not really sure which benchmarks will produce good signal for us, so the parameters will probably need to be tweaked before merging. I'm open to suggestions.

newpavlov commented 1 year ago

I would prefer to keep criterion benchmarks in a separate crate as we do in the stream ciphers repository to prevent criterion being pulled in our CI jobs.