RustCrypto / stream-ciphers

Collection of stream cipher algorithms

264 stars 50 forks source link

Add HC-128 and Fix HC-256 #283

Open quentin-k opened 2 years ago

quentin-k commented 2 years ago

219 This implementation of HC-128 does not yet have the test vectors. HC-256 was using a table size of 2660 instead of 2560, this does not cause issue with the generated key stream, but slightly lengthens the initialization time. The function `h2` in HC-256 used `self.ptable` instead of `self.qtable`, this means that it does not apply linear masking when the stream is using `h2`. For inputs that never get output from `h2` it gives the correct results, but once `h2` is in use the values are incorrect.

newpavlov commented 2 years ago

Can you please rebase and update this PR to cipher v0.4?