search

RustPython / rustpython.github.io

https://rustpython.github.io
MIT License
10 stars 16 forks source link

Webpage to display a set of benchmarks from RustPython #43

Closed theangryhobbit closed 3 years ago

theangryhobbit commented 3 years ago

This PR addresses #42 and thereby also the final part of this issue (2396) from the RustPython repo.

If this PR from the RustPython repo is merged, this PR can display the benchmarks that are being saved to this repo.

Here is an example of how the webpage would look like (given that a set of benchmarks have been committed to this repo) image

And here an example of the webpage given that the set of benchmarks are not available image

The code basically checks if the /assets/criterion/ folder exists and this folder should contain sub-folders with each set of benchmarks. The tabs are programmatically generated from the sub-folder names and the set of benchmarks in these sub-folders form the content of each tab.

theangryhobbit commented 3 years ago

This PR from the RustPython repo has just been merged! This means that the benchmarks webpage would now be able to display the benchmarks that are being saved to this repo.

mireille-raad commented 3 years ago

I think this code looks great and is ready to be merged as well. Thank you so much!

I saw that the Pull Request that generates the benchmarks just got merged. The GitHub action needs time to run since it is a cron job. Let's wait for the first batch of benchmarks to be udpated here and then we merge this (otherwise there will be the error message)

coolreader18 commented 3 years ago

Yup, I think it should run this evening, 0000 UTC Saturday

mireille-raad commented 3 years ago

I saw that @coolreader18 and @nielsbauman added the data manually. Should we merge this for now?

theangryhobbit commented 3 years ago

I saw that @coolreader18 and @nielsbauman added the data manually. Should we merge this for now?

I think we can merge this now 👍