RustPython / rustpython.github.io

https://rustpython.github.io
MIT License
10 stars 16 forks source link

Incorrect code snippet rendering in how-to-contribute-by-cpython-unittest.html #54

Closed tai271828 closed 2 years ago

tai271828 commented 2 years ago

The following code snippet is not rendered correctly. It should be some thing like this: USTPYTHONPATH=Lib cargo run --release ./Lib/test/test_unicode.py (double-dash and grey background)

Selection_550

I checked the markdown syntax with my Atom editor and it looks good. Maybe something else causes the rendering incorrectly.

youknowone commented 2 years ago

Thank you for the report!

The referred document is: https://rustpython.github.io/blog/2020/04/04/how-to-contribute-by-cpython-unittest.html

youknowone commented 2 years ago

For the document itself, I fixed it by fixing the document itself here: https://github.com/RustPython/rustpython.github.io/commit/f962c172e66dd36dec9a80dec739d6a6be86c5b9

mireille-raad commented 2 years ago
Screen Shot 2021-12-01 at 1 42 46 PM

Does this work? should we close the issue?

tai271828 commented 2 years ago

In my opinion, this issue is resolved. Thanks for fixing and confirmation.

mireille-raad commented 2 years ago

of course. Always create issues if you have ideas for content or general improvements.

youknowone commented 2 years ago

The renderer bug itself is not fixed, but document bug is fixed