search

RusticiSoftware / SCORMCloud_NetLibrary

A C# library to assist in the integration of the SCORM Cloud service into .Net 2.0+ applications.
http://scorm.com/scorm-solved/scorm-cloud/develop-a-scorm-cloud-app/
Other
11 stars 22 forks source link

Course Tag methods fix #10

Closed cemerson closed 10 years ago

cemerson commented 10 years ago

Course tag methods weren’t working because the parameter being sent to the web service was “courseID” - and needed to be “courseid”. Fixed and appears to be working now.

brianjmiller commented 10 years ago

@nathaninlatin you the review guy here? (If not please re-assign.)

brianjmiller commented 10 years ago

@cemerson the diff suggests you changed the whole file? Perhaps a line ending issue?

cemerson commented 10 years ago

Only changed a few lines – yeah could be a line ending issue.

From: Brian J. Miller [mailto:notifications@github.com] Sent: Wednesday, July 09, 2014 3:38 PM To: RusticiSoftware/SCORMCloud_NetLibrary Cc: Chris Emerson Subject: Re: [SCORMCloud_NetLibrary] Course Tag methods fix (#10)

@cemersonhttps://github.com/cemerson the diff suggests you changed the whole file? Perhaps a line ending issue?

— Reply to this email directly or view it on GitHubhttps://github.com/RusticiSoftware/SCORMCloud_NetLibrary/pull/10#issuecomment-48523832.

nvrks commented 10 years ago

Sorry this took awhile. Master had a weird .csproj issue that I needed to resolve. Looks good. Thanks. :+1: