RusticiSoftware / SCORMCloud_NetLibrary

A C# library to assist in the integration of the SCORM Cloud service into .Net 2.0+ applications.
http://scorm.com/scorm-solved/scorm-cloud/develop-a-scorm-cloud-app/
Other
11 stars 22 forks source link

Added additional support for postback related calls in RegistrationServices #16

Closed musicm122 closed 9 years ago

musicm122 commented 9 years ago

Added the following methods to Registration service:

musicm122 commented 9 years ago

Sorry about the repeat pulls. Its been one of those days...

nvrks commented 9 years ago

Hi, thanks for this PR. Looks good. I had just the one comment.

musicm122 commented 9 years ago

K updated.

nvrks commented 9 years ago

Hi, so Github's display of my comment was kind of funny. I was commenting on the second TestRegistrationPostUrl function, which already had authType in the parameter list, but which didn't use it. I didn't mean for you to add authType to the other TestRegistrationPostUrl function. It is now on line 611 of RegistrationService.cs…authType is passed in as a parameter to the function but not added as a parameter to the API call.

musicm122 commented 9 years ago

K fixed.

nvrks commented 9 years ago

Thanks! :+1: