RusticiSoftware / SCORMCloud_NetLibrary

A C# library to assist in the integration of the SCORM Cloud service into .Net 2.0+ applications.
http://scorm.com/scorm-solved/scorm-cloud/develop-a-scorm-cloud-app/
Other
11 stars 22 forks source link

Add Dictionary Option to GetLaunchUrl() #30

Closed joshwwarren closed 7 years ago

joshwwarren commented 7 years ago

This allows me to add two additional parameters ("player" and "forceFrameset") without a lot of additional overloads, as well as make overloads unnecessary for future parameter additions.

darrencauthon commented 7 years ago

@rwiggins @brianjmiller This pull request exists to give us the ability to set additional parameters on the request to Rustici. The two we need to send, "player" and "forceFramset" can be passed this way, but we don't know what else is available. Since the base accepts a string-object dictionary, exposing a single parameter of Dictionary<string, object> allows us to pass our two variables, as well as any future variables someone using this library would need.

darrencauthon commented 7 years ago

@brianjmiller @rwiggins @tedwards

How long would it take to deploy a new version of this to nuget?

I don't mean to push... we'd just love to get this off our fork and use the official library again.