Bump Json.NET and NUnit dependencies

RusticiSoftware / TinCan.NET

C#/.NET library for Tin Can API

http://rusticisoftware.github.io/TinCan.NET/

Apache License 2.0

47 stars 57 forks source link

Bump Json.NET and NUnit dependencies #22

Closed brianjmiller closed 8 years ago

brianjmiller commented 8 years ago

Remove NUnit test adapter from nuget dependencies as the 2.x version is not compatible and 3.x is intended to be run with an adapter installed through other means (see new readme)
Correct a failing unit test not compatible with 3.x

Replaces #21 since the deps have increased again since then and this has a slightly different unit test format.

brianjmiller commented 8 years ago

@oconnetf this still look okay to you? I bumped the deps to the new versions and had a little different take on the fixed unit test, also added a readme for adapter installation.

oconnetf commented 8 years ago

Small comment re: preferred syntax. Otherwise, :+1:.

brianjmiller commented 8 years ago

@bscSCORM thoughts?

bscSCORM commented 8 years ago

So it seems that based on this discussion we probably should lean towards Assert.That , perhaps except in the case of ThrowsAsync, though there is disagreement on that as well... in any case, this seems good enough to merge and this discussion is useful for future reference.