search

RusticiSoftware / TinCanAPILibraryCSharp

DEPRECATION NOTICE: This library is deprecated, use the TinCan.NET library instead
http://rusticisoftware.github.io/TinCan.NET/
14 stars 12 forks source link

Prefer Uri to string for Extension Keys #3

Closed oconnetf closed 11 years ago

oconnetf commented 11 years ago

Per spec.

oconnetf commented 11 years ago

Allowing @johnhayden to bless this.

johnhayden commented 11 years ago

This is good and all, but couldn't it be a breaking change? Or perhaps we're not concerned about that yet because of the low usage of this lib. Off to @bscSCORM

oconnetf commented 11 years ago

It's open source, which probably alters our policy a bit.

bscSCORM commented 11 years ago

@oconnetf -- waiting on testing.

Not so concerned about breaking consumers, since it seems to be barely used so far, and they'll presumably have to change for 1.0.0 anyway when they grab the latest version.

Mainly concerned URI type could break JSON deserialization.

oconnetf commented 11 years ago

I successfully used the C# library classes and unit tests to construct and post a statement with extensions to the Cloud public endpoint. Constructing a System.Uri with a string seemed to work fine for constructing an extension.

oconnetf commented 11 years ago

Back to @bscSCORM for final review.