search

RusticiSoftware / TinCanAPILibraryCSharp

DEPRECATION NOTICE: This library is deprecated, use the TinCan.NET library instead
http://rusticisoftware.github.io/TinCan.NET/
14 stars 12 forks source link

Fix lib so 3 unit tests work. #6

Closed nvrks closed 11 years ago

nvrks commented 11 years ago

Tests are: ActivityProfileTest() GetStatementsTest() StoreStatementsTest()

Fixes https://rusticisoftware.atlassian.net/browse/INT-9

@tseabrooks (please reassign if someone else should review this)

tseabrooks commented 11 years ago

This all looks good to me. I haven't tested it. There are some obvious bad lines in there, good fixes.

tseabrooks commented 11 years ago

@bscSCORM Take a look and feel free to merge. I see some obvious bug fixes, changes to URI and name changes to fix serialization. Looks like it was using the wrong values in this .95 section. likely copy pasted from .90

bscSCORM commented 11 years ago

Next time when replacing a bunch of the same string, that's a red flag that string deserves a constant if not a config var (I'm thinking of the test endpoint here).

But not worth going back and changing now.