RusticiSoftware / TinCanJS

JavaScript library for the Experience API (Tin Can API)
http://rusticisoftware.github.io/TinCanJS/
Apache License 2.0
207 stars 115 forks source link

Added Attachments support for LRSs #129

Closed FishHooks closed 8 years ago

FishHooks commented 8 years ago

Rebased with current master and fixed tests to support version 1.0.2

Addresses #70

This PR includes the following:

brianjmiller commented 8 years ago

It would be good to test the additional methods of LRS, and to have a test that sends an attachment, one that retrieves a statement via id, and one that query's statements.

FishHooks commented 8 years ago

This last commit adds tests for the new LRS methods, as well as sending and receiving statements with attachments.

Additionally, I've removed all manual header parsing and used the built-in methods of XHR to handle the response headers.

brianjmiller commented 8 years ago

Based on the other PR going in, this one needs to be merged/rebased with master again to resolve the conflicts. I'd probably lean rebase.

FishHooks commented 8 years ago

Alright. It's refactored, rebased, and retested. I ported the multipart response parsing helper methods straight over from PHP, so it should have everything. The only thing I removed was that PHP had it set up to put the status in the first element of the multipart sections array, so I removed that (I'm guessing it was there because of the way PHP handles the response).

tseabrooks commented 8 years ago

@brianjmiller We need to have this merged.

Thanks, TJ

brianjmiller commented 8 years ago

Closing in favor of #133.