RusticiSoftware / TinCanJS

JavaScript library for the Experience API (Tin Can API)
http://rusticisoftware.github.io/TinCanJS/
Apache License 2.0
207 stars 115 forks source link

Attachments #133

Closed brianjmiller closed 8 years ago

brianjmiller commented 8 years ago

Replaces #129 with proper handling for binary data.

Tested in:

brianjmiller commented 8 years ago

@joshhoffman @tseabrooks said you were the unfortunate soul that should have a glance at this. It looks like a lot of changes, but you can completely ignore the newly added copy of CryptoJS which is just a version bump to get to a version that supports TypedArrays. I've tested this pretty heavily, but welcome feedback in general. But if you start to run into lots of questions best to come find me in person and we can talk about the overall methodology of how TinCanJS is tested, maintained, released, etc.

joshhoffman commented 8 years ago

👍 @brianjmiller sending back to you to commit or second review if necessary