Handle slightly incorrect inputs

[garemoko]

The js library should be able to handle:

• LRS endpoints that lack the final /
• mbox values that lack the initial "mailto:" (this is already handled if the mailbox is set when the actor is created, but not if the property is defined later e.g. on the next line. For use case, see https://github.com/garemoko/tinStatement/blob/cdbcc0bce1f3b0d7c97bfc3d0bdd2a5e0fc5a623/TinStatement.js#L135)

[brianjmiller]

@garemoko I have a commit pending for the '/' thing that will go into a PR. In the second case I didn't understand the use case, the linked code appears to be during Agent instantiation which should correct for the 'mailto:'. Since we don't have a setter pattern yet it is really up to the user to only specify appropriate values to be stored in the 'mbox' property, which is unfortunate, but I don't know that we want to introduce the whole .get/.set pattern yet (though I've been debating it for a while). Can you explain more what you meant by this? Or does it make sense to close the second part as "won't fix" (until .set/.get pattern emerges)?

[garemoko]

Hi Brian, This was a while ago and I can't explain the relevance of the linked code. I think the use case was if you set or change mailto later on, so yes this is a call for getters and setters I guess!

Andrew

"Brian J. Miller" notifications@github.com wrote:

@garemoko I have a commit pending for the '/' thing that will go into a PR. In the second case I didn't understand the use case, the linked code appears to be during Agent instantiation which should correct for the 'mailto:'. Since we don't have a setter pattern yet it is really up to the user to only specify appropriate values to be stored in the 'mbox' property, which is unfortunate, but I don't know that we want to introduce the whole .get/.set pattern yet (though I've been debating it for a while). Can you explain more what you meant by this? Or does it make sense to close the second part as "won't fix" (until .set/.get pattern emerges)?

— Reply to this email directly or view it on GitHub.

[brianjmiller]

Closing as I think the remaining request of using a get/set model is captured by the roadmap #110.