search

RusticiSoftware / TinCanJS

JavaScript library for the Experience API (Tin Can API)
http://rusticisoftware.github.io/TinCanJS/
Apache License 2.0
207 stars 115 forks source link

Various fixes from Cross browser testing #43

Closed brianjmiller closed 11 years ago

brianjmiller commented 11 years ago

Fixes implemented while extensively testing CORS support in all modern browsers.

Tested in IE7-IE10, FF 21, Chrome 27, Safari 6.0.4. IE6 doesn't work, and AFAICT never did. Cross domain tested in all browsers except for IE7 (which doesn't support it) and in that case the not supporting cross domain alert worked.

brianjmiller commented 11 years ago

@brianrogers to you for review.

brianjmiller commented 11 years ago

@tseabrooks first to respond, you get the call.

tseabrooks commented 11 years ago

@bscSCORM Looks good. My only questions for @brianjmiller, Did we recently change LRS version to be .9 from .90 or has test cfg just been wrong for .9?

brianjmiller commented 11 years ago

I think it has just been wrong in the template, it was right in my local version but that change never got switched to the template. I reset my local copy when adding the 1.0.0 block to the template to make sure and it failed, that's when I noticed to fix it.