search

RusticiSoftware / TinCanJS

JavaScript library for the Experience API (Tin Can API)
http://rusticisoftware.github.io/TinCanJS/
Apache License 2.0
207 stars 115 forks source link

Fix context.StatementRef #98

Closed garemoko closed 9 years ago

garemoko commented 9 years ago

Resolves #91

Supersedes https://github.com/RusticiSoftware/TinCanJS/pull/94

brianjmiller commented 9 years ago

A few style issues, I'll go through them and give you a commit.

brianjmiller commented 9 years ago

My changes for the various issues I found are in this commit:

https://github.com/brianjmiller/TinCanJS/tree/pr88

Please have a look and make sure I didn't screw up anything that you'd done. It should be a fast forward merge to your branch. See comments for some references of what I did. I expanded a few of the test cases as well.

garemoko commented 9 years ago

Looks good to me and nice to have substatement covered for earlier versions. Will get your commit now.

brianjmiller commented 9 years ago

:+1: over to you @bscSCORM.