search

RusticiSoftware / TinCanJava

Tin Can Java Library
http://rusticisoftware.github.io/TinCanJava/
Apache License 2.0
44 stars 46 forks source link

Initial Implementation #1

Closed brianjmiller closed 11 years ago

brianjmiller commented 11 years ago

Switching this to actual review status.

Ping @davidells-scorm and anyone else for further review.

ghost commented 11 years ago

@brianjmiller

Ah, almost forgot, officially done with comments for this round.

brianjmiller commented 11 years ago

This needs second review before going to master. But alas I'm shipping it based off this commit to go over to Lifeway.

@davidells-scorm

ghost commented 11 years ago

@brianjmiller @bscSCORM

Reviewed PR feedback commit... Left one additional comment, but don't consider it necessary to hold up a merge.

On to you @bscSCORM

bscSCORM commented 11 years ago

Back to you @brianjmiller , please address the comments above and then get back to me.

I hope you'll get a chance to fill out more tests after this PR is wrapped up.

brianjmiller commented 11 years ago

"I hope you'll get a chance to fill out more tests after this PR is wrapped up."

Me too.

I think I've addressed all the comments in here, if I missed any then it is an oversight rather than my ignoring them. Please have another pass at review @davidells-scorm, @bscSCORM

brianjmiller commented 11 years ago

Back to you @bscSCORM .