search

RusticiSoftware / TinCanJava

Tin Can Java Library
http://rusticisoftware.github.io/TinCanJava/
Apache License 2.0
44 stars 46 forks source link

GZipped request body support. #15

Closed zachlowry closed 10 years ago

zachlowry commented 10 years ago

Adds support for a GZipped request body in TinCanJava. Also sets the threadpool for HTTPClient to use Daemon mode, so that HTTPClient threads won't cause Tomcat to hang on exit.

brianjmiller commented 10 years ago

I'm curious what the ramifications for setting the thread pool are. As I am a newbie Java developer I assume this is just something Java developers know, because I found very little about what that is actually doing. I trust you are right, but I'd like to know what it was necessary?

zachlowry commented 10 years ago

The rationale here is to make sure that threads that may be running when the application begins to exit don't prevent the application from exiting. I tried to keep everything else the same, and just change that one property.

On Fri, Feb 14, 2014 at 10:19 AM, Brian J. Miller notifications@github.comwrote:

I'm curious what the ramifications for setting the thread pool are. As I am a newbie Java developer I assume this is just something Java developers know, because I found very little about what that is actually doing. I trust you are right, but I'd like to know what it was necessary?

Reply to this email directly or view it on GitHubhttps://github.com/RusticiSoftware/TinCanJava/pull/15#issuecomment-35098206 .