search

RusticiSoftware / TinCanJava

Tin Can Java Library
http://rusticisoftware.github.io/TinCanJava/
Apache License 2.0
44 stars 46 forks source link

Rewrite of LRS interface and RemoteLRS #27

Closed brianjmiller closed 10 years ago

brianjmiller commented 10 years ago

This is an extension of what was originally PR #23. Original description:

"-LRS, RemoteLRS, About, LRSResponses, and Documents brought updated to new architecture. -ContextActivities and TCAPIVersion modified to handle receiving V101 responses -HTTPRequest and HTTPResponse modified. HTTPRequest no longer extends ContentExchange. It instead stores the relevant data for a request, and the ContentExchange is constructed in a private function in RemoteLRS."

This adds a few commits that primarily fixes a precision issue with result.duration.

brianjmiller commented 10 years ago

@bscSCORM I'd like to start getting your comments on this PR pending the addition of Etag support in save/retrieve of documents. Tests pass and are greatly improved. This is originally @jakednoble's work, with my additions, that is hopefully sufficient 2 coder review.

brianjmiller commented 10 years ago

Travis-CI now building + testing correctly!

bscSCORM commented 10 years ago

:+1: @brianjmiller did you want me to merge this or were you just looking for comments? I don't have anything to bring up except the 'throws exception' note

brianjmiller commented 10 years ago

I think we are going to try to rework the exceptions to remove the need for them, which is seemingly possible based on the LRS response object's success property. So hold on merge.

brianjmiller commented 10 years ago

Okay, back to you @bscSCORM. Exceptions are no longer propagated, @jakednoble and I had some discussions about how we are using them, but I'd like to get your feedback. May lead to more discussion which is good.