search

RusticiSoftware / TinCanJava

Tin Can Java Library
http://rusticisoftware.github.io/TinCanJava/
Apache License 2.0
44 stars 46 forks source link

RemoteLRS Improvements #34

Closed brianjmiller closed 9 years ago

brianjmiller commented 9 years ago
brianjmiller commented 9 years ago

@dacdave Can you have a look at this to make sure I captured everything pertinent from #33? I corrected the tabs to spaces and took care of some already existing whitespace issues. I also added the same functionality for the State API.

And fixed the Travis CI build so that tests now run correctly on that system. If you are good with this we'll get it reviewed by a second person and then merged. I'll cut a release after that merge.

dacdave commented 9 years ago

Brian,

I saw your PR messages and scanned the code. I do not see any issues, but will look closer later, hopefully… Please don’t wait on me.

Dave Smith

Brindle Waye, Ltd.

866-522-9839 x823

Design-a-Course

The Easiest Way to Train Anyone…Anywhere!

Like us on http://www.facebook.com/brindleadmin Facebook and follow us on http://www.linkedin.com/company/915700 LinkedIn!

From: Brian J. Miller [mailto:notifications@github.com] Sent: Monday, April 6, 2015 1:51 PM To: RusticiSoftware/TinCanJava Cc: Dave Smith Subject: Re: [TinCanJava] RemoteLRS Improvements (#34)

@dacdave https://github.com/dacdave Can you have a look at this to make sure I captured everything pertinent from #33 https://github.com/RusticiSoftware/TinCanJava/pull/33 ? I corrected the tabs to spaces and took care of some already existing whitespace issues. I also added the same functionality for the State API.

And fixed the Travis CI build so that tests now run correctly on that system. If you are good with this we'll get it reviewed by a second person and then merged. I'll cut a release after that merge.

— Reply to this email directly or view it on GitHub https://github.com/RusticiSoftware/TinCanJava/pull/34#issuecomment-90172774 . https://github.com/notifications/beacon/ADrbXeu2isN4SQQoPegfGaXozAkidLlWks5n8r8LgaJpZM4D7Aa8.gif

brianjmiller commented 9 years ago

@bscSCORM I've reviewed this and just made the changes I would have suggested, not sure if that warrants a second reviewer, if so feel free to assign.