Closed alycklama closed 8 years ago
Please switch tabs to 4 spaces.
_httpClient
is a static so this method probably ought to be as well, and it needs to set the property to null
so that subsequent calls (which I realize is odd) causes the value to be re-instantiated.
Based on above comment it might make more sense to rename the method to something being more specific, kind of like the existing setHTTPClientConnectTimeout
method.... destroyHTTPClient
perhaps?
@alycklama thanks for the submission, thoughts on the above?
+1 for the idea of making the method static, renaming it and setting the static attribute to null. I think that it would probably avoid confusions.
Closing this based on inactivity and #50 capturing the important concepts.
Threads remain active within Java EE applications, without decent shutdown