search

RusticiSoftware / TinCanJava

Tin Can Java Library
http://rusticisoftware.github.io/TinCanJava/
Apache License 2.0
44 stars 46 forks source link

* Turn on 1.0.0, and add 1.0 query API support #7

Closed ghost closed 11 years ago

ghost commented 11 years ago
ghost commented 11 years ago

@brianjmiller

Take a gander. (*Award brownie points for not introducing tabs...)

brianjmiller commented 11 years ago

@davidells-scorm see above comments, then I think it'll be good to go. Will need to do the maven release plugin thang when it is ready.

ghost commented 11 years ago

@brianjmiller Added a couple tweaks in a feedback commit, a couple comments, and an open question or two.

Should I be running the release plugin goals as part of this PR, or is that just something to do off of master once this is merged in?

brianjmiller commented 11 years ago

:thumbsup: to @bscSCORM . The release plugin goals get run after this is merged to master. That will trigger the proper tagging, version bumps, etc.

ghost commented 11 years ago

@bscSCORM

Try catch didn't make any sense there anyway, so removed catch / log entirely