search

RusticiSoftware / TinCanPHP

PHP library for the Experience API (Tin Can API)
http://rusticisoftware.github.io/TinCanPHP/
Apache License 2.0
87 stars 78 forks source link

Enable setting headers on `RemoteLRS.queryStatements` #67

Closed brianjmiller closed 8 years ago

brianjmiller commented 8 years ago

Fixes #26.

brianjmiller commented 8 years ago

@garemoko care to review?

garemoko commented 8 years ago

Code looks good. Would be nice to include a test.

garemoko commented 8 years ago

The test would go around here: https://github.com/RusticiSoftware/TinCanPHP/pull/67

I'm thinking we set the X-Experience-API-Version to "11" and test for a 400 response.

brianjmiller commented 8 years ago

Tests would be good, but at this point I'm trying to get all of the things in, honestly I think to get better coverage in this lib we need to switch to mocking the LRS or the HTTP request, and that is a much bigger task than I'm willing (or able) to take on at the moment.

garemoko commented 8 years ago

Cool. If I get some time this week I might add the test I suggested as a separate PR.