search

RusticiSoftware / TinCanPHP

PHP library for the Experience API (Tin Can API)
http://rusticisoftware.github.io/TinCanPHP/
Apache License 2.0
87 stars 80 forks source link

restore scaled value functionality #75

Closed texdc closed 8 years ago

texdc commented 8 years ago

fixes #74

I'm still not clear on how a mastery score is calculated or used, but this will restore expected functionality.

brianjmiller commented 8 years ago

@texdc thanks for contribution, I unfortunately had already taken a bit more of a knife to this, but just hadn't had a chance to commit because of another issue I found (which was unrelated completely). Please have a look at https://github.com/RusticiSoftware/TinCanPHP/pull/50/commits/dbd8b3f24041683276598bfdc9fbdeed2e3920e0 which is part of #50 and see if there is anything problematic in there. I dropped getValue and validate completely which would be the biggest backwards compatibility problem.

As far as "mastery score" is concerned, basically the concept doesn't exist in a purely xAPI world, though scaled is intended to capture effectively the value that would match up to a "mastery score" like value. Having said that, the newly released (for production use) cmi5 specification does include the concept of a mastery score and instructs on how to capture the value. See https://github.com/AICC/CMI-5_Spec_Current/blob/quartz/cmi5_spec.md#au_meta_data (and the various other related bits).

I'm going to close this in favor of the work in #50, feel free to comment here or there with concerns.