Rutuj-Runwal / RR-Adblocker

A browser extension that blocks ads and trackers to make your web surfing faster and safer.
https://rutuj-runwal.github.io/RRAdblocker/
GNU General Public License v3.0
31 stars 31 forks source link

💡 Addition of Contribution Page inside options #24

Closed Rutuj-Runwal closed 2 years ago

Rutuj-Runwal commented 2 years ago

Description

Integrating a github contributors page inside the options page shown below via a button The page should have the following:

You can use the github api to fetch all the active contributors in real time:
https://api.github.com/repos/Rutuj-Runwal/RR-Adblocker/contributors

image

New to the repo?

Check out the getting started guide to help you with the contributions:

https://github.com/Rutuj-Runwal/RR-Adblocker/blob/main/Getting_Started.md

ghost commented 2 years ago

Hello, I'd like to take this issue

Rutuj-Runwal commented 2 years ago

Hello, I'd like to take this issue

Sure

ghost commented 2 years ago

Contributions has been added

Rutuj-Runwal commented 2 years ago

Contributions has been added

@PaxtonDevs your design is great but you have hard-coded all the contributors into the html which is not ideal.As if a new contributor joins in we have to update the page every time. What you need to do here is to use the GitHub api(link mentioned in the issue description), it gives a JSON object. You need to loop over it and dynamically insert the contributors with javascript.

ghost commented 2 years ago

Thank you for the feedback, I will make these changes.

Rutuj-Runwal commented 2 years ago

Thank you for the feedback, I will make these changes.

Sure👍🏻

ghost commented 2 years ago

Updates have been added.