RuurdBijlsma / tm-split-speeds

TrackMania Openplanet plugin to show speed difference to your personal best at checkpoints.
https://openplanet.dev/plugin/splitspeeds
GNU General Public License v3.0
2 stars 7 forks source link

Add MultiLap support for MP4 & Turbo, Fix Turbo not even working #22

Closed TigerGorilla2 closed 3 months ago

TigerGorilla2 commented 3 months ago

I have changed this PR to a Draft again since i have reorganized the commits/changes into more logical steps that are easier to review. I'll not open PRs for them yet tho and let you decide if you want to keep using this or the reorganized commits (which I'd prefer). I have a branch for each category of changes:

  1. General fixes, most importantly Turbo works again
  2. Add MultiLap support
  3. Add support for unfinished runs
  4. Refactoring. Replacing Tabs with Spaces, remove spaces at the end of lines, make spaces consistent (if (, for (, ) {

Changes:

Note: I have upgraded the splits-file version to 2. The only difference to v1 is the meaning in MP4 & Turbo contexts to indicate that it supports MultiLaps. When you load a MultiLap map in MP4 & TmTurbo with an old (version < 2) splits-file it will be deleted! Reasoning is that it does only contain splits for one lap is therefore useless.

TODO: - I (@TigerGorilla2) want to do some more testing Done

RuurdBijlsma commented 3 months ago

I will test this when I have time, but it's a busy week for me. Thx for the pr

TigerGorilla2 commented 3 months ago

Closed in favor of https://github.com/RuurdBijlsma/tm-split-speeds/pull/24 & https://github.com/RuurdBijlsma/tm-split-speeds/pull/25