search

RuurdBijlsma / tm-split-speeds

TrackMania Openplanet plugin to show speed difference to your personal best at checkpoints.
https://openplanet.dev/plugin/splitspeeds
GNU General Public License v3.0
2 stars 7 forks source link

Add support for unfinished runs #23

Closed TigerGorilla2 closed 3 months ago

TigerGorilla2 commented 3 months ago

This adds support for using the splits from the furthest unfinished run if there isn't a finished one (PB or Session).

This PR currently builds on top of #22, that's why it contains so many changes. It should also work standalone (though I haven't tested that) and I can base this on current master if you want that for some reason. :)

TigerGorilla2 commented 3 months ago

I have just realized that I don't know how the game decides which ghost (longest driving distance, longest driving time, most checkpoints collected, most recent run, or some combination) to show when there isn't a completed run yet. This would make the ghost and split diffs not match up. I will do some testing to find out...

TmNext: If you haven't collected a checkpoint in any run, the longest run is used as the Ghost. Then the run with the most collected checkpoints in the quickest time becomes the Ghost. MP4: Ghosts are the last finished run of the session. When choosing Drive Alone and not having finished a run it uses the previous unfinished run as an Opponent (unless the run was shorter than ~4sec). When choosing an Opponent no ghost is shown until a run is finished. TmTurbo: TODO

For TmNext using the splits of the (unfinished) run with the most checkpoints collected in the quickest time is the only reasonable option here. For MP4 and TmTurbo it's probably not a bad idea to do the same as with TmNext

TigerGorilla2 commented 3 months ago

Now for unfinished runs the splits of the run with the most checkpoints collected is used. If there is a tie in the amount of checkpoints the runs splits which got those first is used.

TigerGorilla2 commented 3 months ago

The last commit (4bcf232) fixed a bug where entering / resetting on a map with a MultiLap start block it would count that as crossing the MultiLap block. This was not a problem before since

  1. Entering the map it would add the speed and only afterwards HandleRunStart is called
  2. Resetting mid run was just ignored as unfinished runs were ignored

Note on 1.: A map switch is required, i.e. exiting the map and "directly" entering it again doesn't work

TigerGorilla2 commented 3 months ago

Closed in favor of https://github.com/RuurdBijlsma/tm-split-speeds/pull/26