search

Ruzihm / coin-chance

An open source crypto currency play-and-invest gambling site
GNU Affero General Public License v3.0
35 stars 23 forks source link

Question - SSL #5

Closed fedaykinofdune closed 10 years ago

fedaykinofdune commented 10 years ago

Is it necessary to use SSL or can I leave off the path to cert if I don't wish to use it? And, is this finished enough to use live?

Ruzihm commented 10 years ago

I have added the option to disable SSL, but I absolutely recommend that it STAYS ON in a production environment.

I wouldn't use it live just yet, I have concerns about a race condition that could come up, allowing a user to be credited twice for one deposit (#1). I'll reply to this thread when I can get around to fixing that.

And on a smaller note, I have just added in support for a REDIS type, which should perform better in a production environment. It should work, provided that the SESSION_STORE_OPTIONS dictionary is set up properly ('client' is set up at app start time and does not need to be specified in the config file). If there are any problems with it please reply here. It also requires a Redis server to be running.

Aside from those two things, I think it is ready to be used in production. Just be sure to set SRC_LINK to either:

fedaykinofdune commented 10 years ago

Excellent, thanks for the response. I have tons going on, but I am going to get around to test driving it very soon! Very awesome of you to make something like this open source.

On Fri, May 2, 2014 at 11:47 PM, Richard Van Tassel < notifications@github.com> wrote:

I have added the option to disable SSL, but I absolutely recommend that it STAYS ON in a production environment.

I wouldn't use it live just yet, I have concerns about a race condition that could come up, allowing a user to be credited twice for one deposit (

1 https://github.com/Ruzihm/coin-chance/issues/1). I'll reply to this

thread when I can get around to fixing that.

And on a smaller note, I have just added in support for a REDIS type, which should perform better in a production environment. It should work, provided that the SESSION_STORE_OPTIONS dictionary is set up properlyhttps://github.com/visionmedia/connect-redis/tree/1.4.7#options('client' is set up at app start time and does not need to be specified in the config file). If there are any problems with it please reply here. It also requires a Redis server to be running.

Aside from those two things, I think it is ready to be used in production. Just be sure to set SRC_LINK to either:

  • A url to your version of code (i.e., a github page or a store if you wish to sell your source code.)
  • Or as an empty string, which will cause the server to package up the code on startup and host it as a .tar.gz file.

— Reply to this email directly or view it on GitHubhttps://github.com/Ruzihm/coin-chance/issues/5#issuecomment-42096244 .

Ruzihm commented 10 years ago

1 is fixed in the 0.3.0 version! No known bugs at the moment :)

Ruzihm commented 10 years ago

I'm going to go ahead and close this. Feel free to keep commenting though ;)

fedaykinofdune commented 10 years ago

Awesome, hopefully by tonight I'll have 2 sites running it. Can't wait!

On Mon, May 5, 2014 at 9:03 AM, Richard Van Tassel <notifications@github.com

wrote:

Closed #5 https://github.com/Ruzihm/coin-chance/issues/5.

— Reply to this email directly or view it on GitHubhttps://github.com/Ruzihm/coin-chance/issues/5#event-117837543 .

Ruzihm commented 10 years ago

So I committed a tag with the fix, but didn't commit it non-tagged. Now, both non-tag and 0.3.0 tag have that fix in.

Apparently I still have some things to learn about Git! Haha.