Closed Rwatana closed 4 months ago
@ryuji0123 I believe I have implemented the code according to your instructions. Could you please review my changes?
Sure, I will prepare a sequential graph for our understanding. Regarding my schedule, I am participating in a 2-day Infrastructure internship hosted by CyberAgent this weekend. Therefore, the earliest I can meet is the following weekend. Thank you for your understanding.
Topic
I have prepared two main components for logging. In this Pull Request (PR), I completed the function for sending logs to the Go server and the process for transmitting these logs from the Go server to the database (DB).
I established a baseline for this, and in the next PR, I will integrate the function into various parts of my code.
Modify Points
Test
I executed
sendDemo.js
located at:I received the following results on the Go server:
I also ran the code
sendLogtoDB.go
located at:Upon success, I received:
Upon failure, I received:
In the DB section, the logs were recorded as follows:
Question
I think my PR includes too many changes, and I should have separated it into smaller PRs. However, I'm not sure how to do this effectively. For the future, I would like guidance on how to properly structure and split PRs to ensure they are manageable.