Rwothoromo / WeConnect-App

Business review application API
https://weconnect-api-v2-rwothoromo.herokuapp.com/apidocs/
0 stars 1 forks source link

[WIP]Persistent data #11

Closed Rwothoromo closed 6 years ago

Rwothoromo commented 6 years ago

Review and feedback needed.

So far, I am working on api version 2 and have adjusted the auth endpoints to use persistent data and I am doing the same for business endpoints.

I will thereafter have to implement:

  1. search by name using a get parameter q
  2. filter businesses by category or location
  3. pagination.

I will also update the api documentation to reflect any changes.

@collin5 Could you take a look?

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 316


Changes Missing Coverage Covered Lines Changed/Added Lines %
manage.py 6 7 85.71%
app/models/review.py 14 15 93.33%
app/models/business.py 16 17 94.12%
app/models/category.py 12 14 85.71%
app/models/blacklist.py 10 12 83.33%
app/models/location.py 12 14 85.71%
app/models/user.py 12 14 85.71%
app/api/v2/resources/auth.py 66 68 97.06%
app/api/v2/resources/business.py 152 162 93.83%
<!-- Total: 515 538 95.72% -->
Totals Coverage Status
Change from base Build 233: -0.7%
Covered Lines: 690
Relevant Lines: 718

💛 - Coveralls
Rwothoromo commented 6 years ago

Updates were made in #12