RxSwiftCommunity / Action

Abstracts actions to be performed in RxSwift.
MIT License
875 stars 150 forks source link

breakRetainCycle: Break retain cycle in bind(to:input:) #228

Closed nflahavan closed 3 years ago

nflahavan commented 3 years ago

https://github.com/RxSwiftCommunity/Action/issues/227

This pull request breaks the retain cycle in the various bind(to:input:) methods. Tests have also been added to ensure no retain cycle is introduced by calling bind(to:input:).

bobgodwinx commented 3 years ago

sounds like a plan @nflahavan Thanks for spotting it out.. 👍🏾

rxswiftcommunity[bot] commented 3 years ago

Thanks a lot for contributing @nflahavan! I've invited you to join the RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like more information on what this means, check out our contributor guidelines and feel free to reach out with any questions.

Generated by :no_entry_sign: dangerJS