search

RxSwiftCommunity / Action

Abstracts actions to be performed in RxSwift.
MIT License
875 stars 150 forks source link

Flatted the nested ActionError #230

Closed mykoma closed 3 years ago

mykoma commented 3 years ago

When use the Action nest in another Action, it will underlyingError the error two times.

So , I think it's better underlyingError once.

ashfurrow commented 3 years ago

Hmm, that's an interesting use case I hadn't considered. I think that if a developer nests an Action within an Action, then they should be responsible for the nested errors, too. That is to say, with this PR, we are hiding information from the developer because they'll be unable to determine which Action produced the error.

I know the PR is already closed but wanted to outline my thinking here in case I missed something. If anyone thinks this is a good idea, please speak up!

And thank you @mykoma for the PR 🙇