search

RxSwiftCommunity / RxAnimated

Animated RxCocoa bindings
MIT License
687 stars 38 forks source link

[WIP] initial PR #1

Closed icanzilb closed 7 years ago

icanzilb commented 7 years ago

As per @freak4pc suggestions:

image

icanzilb commented 7 years ago

image

freak4pc commented 7 years ago

Nice !! Looks very cool! The only thing I think this still doesn't solve is adding custom animations? AnimationType is still an enum but it doesn't conform to some general protocol that other animation types can implement I think ?

Not sure though if that's still necessary as those are bind-only animations anyways so ¯_(ツ)_/¯

icanzilb commented 7 years ago

@freak4pc sorry, maybe I should've been clearer in the comment :) I just added your code samples to the conversation here so we don't lose them in the Slack history :)

icanzilb commented 7 years ago

I'd never use a dark editor background myself :)))

freak4pc commented 7 years ago

Oh cool cool :) Got it 👍 You wrote "as per suggestions" so I got confused :D

LOL about the editor 😂

EDIT: OH DUH i just realized the commits are older than the screenshot. Not enough coffee today :)

icanzilb commented 7 years ago

Well, this is the beta version of the initial release, elt's do it!