search

RxSwiftCommunity / RxAnimated

Animated RxCocoa bindings
MIT License
688 stars 38 forks source link

Yet another Carthage support #37

Closed mickamy closed 4 years ago

mickamy commented 4 years ago

There are some PRs trying to add Carthage support (#7 or #28). But all of them are stale and I can no see any progress for a long time.

So I created a yet another Carthage support PR.

mickamy commented 4 years ago

@fassko Is it possible to review/merge this one?

fassko commented 4 years ago

@mickamy thanks for your contribution. I haven't used Carthage myself. Can you tell how to test this?

mickamy commented 4 years ago

Actually this PR does not work well for now. Because of the absence of the .xcodeproj file in this repo.

AFAIK, Carthage searches xcodeproj or xcworkspace file in repo on running carthage update or some other command to install, to detect Shared scheme contained in it so that Carthage can build it.

There is an issue discussing about supporting SwiftPM managed project in Carthage though, it seems have no progress lately. ref: https://github.com/Carthage/Carthage/issues/1226

I guess we need to manage xcodeproj file again to support Carthage for now. Any thoughts on this?

@fassko

mickamy commented 4 years ago

Updated PR and included .xcodeproj file to repo. And I also created a repo that proves my implementation works fine. https://github.com/mickamy/RxAnimatedCarthageExample

@fassko Is it enough for testing? I can update example or whatsoever quickly, because I stay home for the COVID-19 situation.

rxswiftcommunity[bot] commented 4 years ago

Thanks a lot for contributing @mickamy! I've invited you to join the RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like more information on what this means, check out our contributor guidelines and feel free to reach out with any questions.

Generated by :no_entry_sign: dangerJS

fassko commented 4 years ago

Thanks @mickamy