Remove unnecessary .touchDownRepeat event from rx.isHighlighted - Githubissues

RxSwiftCommunity / RxCocoa-Texture

RxCocoa Extension Library for Texture.

MIT License

100 stars 53 forks source link

Remove unnecessary .touchDownRepeat event from rx.isHighlighted #25

Closed innocarpe closed 5 years ago

innocarpe commented 5 years ago

Context

I added .touchDownRepeat in #23 for test environment.

- (void)touchesBegan:(NSSet *)touches withEvent:(UIEvent *)event
{
  ...

  // Send the appropriate touch-down control event depending on how many times we've been tapped.
  ASControlNodeEvent controlEventMask = (theTouch.tapCount == 1) ? ASControlNodeEventTouchDown : ASControlNodeEventTouchDownRepeat;
  [self sendActionsForControlEvents:controlEventMask withEvent:event];
}
}

But it's not needed in production environment.

Changes

Created UITouchStub internal class only for the spec which tests observing isHighlighted
- It overrides tapCount so that tapCount can be manipulated
Did some workaround with UITouchStub to pass the test
Remove unnecessary .touchDownRepeat event from rx.isHighlighted

GeekTree0101 commented 5 years ago

Thank you for your contribution!