search

RxSwiftCommunity / RxCoreData

RxSwift extensions for Core Data
MIT License
164 stars 68 forks source link

Swift 4 #24

Closed AYastrebov closed 6 years ago

AYastrebov commented 6 years ago
AYastrebov commented 6 years ago

@bobgodwinx I've update the the swift version, thanks, missed that. Also updated the travis file. I think podfile.lock shouldn't be deleted, it should build now, but I can't access travis and check it

bobgodwinx commented 6 years ago

@AYastrebov I was referring also to the Podfile is in the RxCoredata\Example you can remove this code below + and also delete the Podfile.lock from that same directory. Before running pod install

#post_install do |installer|
#    installer.pods_project.targets.each do |target|
#        target.new_shell_script_build_phase.shell_script = "mkdir -p $PODS_CONFIGURATION_BUILD_DIR/#{target.name}"
#        target.build_configurations.each do |config|
#            config.build_settings['SWIFT_VERSION'] = '4.0'
#            config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '9.0'
#            config.build_settings['CONFIGURATION_BUILD_DIR'] = '$PODS_CONFIGURATION_BUILD_DIR'
#        end
#    end
#end

I just tested it now. This should fix example project. The swift 4.0 is now set perfect 👍

AYastrebov commented 6 years ago

@bobgodwinx ok, got it. Updated the PR

bobgodwinx commented 6 years ago

@AYastrebov Working fine great job 🥇