RxSwiftCommunity / RxCoreLocation

RxCoreLocation is a reactive abstraction to manage Core Location.
https://github.com/RxSwiftCommunity/RxCoreLocation
MIT License
181 stars 82 forks source link

Retrieve wrapper around CLGeocoder? #36

Open lordzsolt opened 4 years ago

lordzsolt commented 4 years ago

I noticed, with the current implementation, all the placemark methods internally create an instance of CLGeocoder.

I would like to ask, what is your opinion on exposing them publicly, and putting a Reactive extension on CLGeocoder? I don't mind doing it myself, so long as the idea gets approved.

Benefits would be that you can do reverse geocoding on any CLLocation, not just the user's current location.

bobgodwinx commented 4 years ago

I think it's a good idea. 👍🏾 Do you have a PR for this ?

lordzsolt commented 4 years ago

I will get one ready this week.