Fix iOS, tvOS Deployment target & Travis CI build fail

RxSwiftCommunity / RxDataSources

UITableView and UICollectionView Data Sources for RxSwift (sections, animated updates, editing ...)

MIT License

3.1k stars 496 forks source link

Fix iOS, tvOS Deployment target & Travis CI build fail #399

Closed ElonPark closed 3 years ago

ElonPark commented 3 years ago

change iOS, tvOS Deployment target equal to SwiftPM, CocoaPods indicated version

- IPHONEOS_DEPLOYMENT_TARGET = 12.0;
+ IPHONEOS_DEPLOYMENT_TARGET = 9.0;
- TVOS_DEPLOYMENT_TARGET = 12.0;
+ TVOS_DEPLOYMENT_TARGET = 9.0;

Also fix Travis CI build fail
- carthage update --platform tvOS && carthage build --no-skip-current --platform tvOS

iamszabo commented 3 years ago

Is there any reason this cannot be merged to master? @freak4pc

Unknoob commented 3 years ago

Can we get this merged? Both versions 5.0.0 and 5.0.1 are broken on carthage and this PR would fix it.

valerianb commented 3 years ago

@freak4pc Hi, would very much appreciate if this could get merged and have a release with it. Thanks 😊

freak4pc commented 3 years ago

Sorry, I haven't been looking into RxDataSources enough lately :) It seems specifically the Carthage-related CI isn't building with this change. Could you fix it and I'll merge and cut a new release? Thanks.

https://travis-ci.org/github/RxSwiftCommunity/RxDataSources/jobs/770505930

@ElonPark @valerianb

ElonPark commented 3 years ago

@freak4pc i'll check it

ElonPark commented 3 years ago

Travis CI build fail is side effect of #392

rxswiftcommunity[bot] commented 3 years ago

Thanks a lot for contributing @ElonPark! I've invited you to join the RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like more information on what this means, check out our contributor guidelines and feel free to reach out with any questions.

Generated by :no_entry_sign: dangerJS