search

RxSwiftCommunity / RxDataSources

UITableView and UICollectionView Data Sources for RxSwift (sections, animated updates, editing ...)
MIT License
3.07k stars 485 forks source link

Different version in .podspec from release tag #405

Open GritGem opened 2 years ago

GritGem commented 2 years ago

Differentiator.podspec and RxDataSources.podspec has old version 5.0.0 in 5.0.2 release.

engali94 commented 2 years ago

Hey @GritGem Could you please open PR?

alandeguz commented 2 years ago

@engali94 - Would a PR actually fix the issue? The tagged version 5.0.2 is already released.

If I pod update with 5.0.2 (or 5.0.1), I get this error message (no error with 5.0.0).

[!] CocoaPods could not find compatible versions for pod "RxDataSources":
  In Podfile:
    RxDataSources (= 5.0.2)

None of your spec sources contain a spec satisfying the dependency: `RxDataSources (= 5.0.2)`.

You have either:
 * mistyped the name or version.
 * not added the source repo that hosts the Podspec to your Podfile.

Presumably the fix is to release 5.0.3, potentially featureless, and make the Podspec change to 5.0.3 along with a tagged release.

GritGem commented 2 years ago

I believe it source version under tag 5.0.0 due to not incremented version in .podspec. You might also just publish updated .podspec for 5.0.1 and 5.0.2 and it would be available through cocoapods. Just be aware of not matching .podspec tagged under those tags and those published to official repo. You might update them and re-tag but not sure if it is the right procedure for publicly available repo... Anyway I believe it goes beyond PR fix. (@alandeguz suggestion with 5.0.3 seem also fine)