search

RxSwiftCommunity / RxFirebase

RxSwift extensions for Firebase
MIT License
224 stars 66 forks source link

PhoneAuthProvider support #14

Closed shvetsjr closed 5 years ago

shvetsjr commented 5 years ago

Would be nice with support for phone number authentification.

arnauddorgans commented 5 years ago

What do you need ? PhoneAuthProvider.provider().verifyPhoneNumber ?

arnauddorgans commented 5 years ago

@ShvetsJr tell me if you need something else, otherwise i'll merge #15

shvetsjr commented 5 years ago

Yes, cool! Thanks!

Would be nice to have Auth.auth().signInAndRetrieveData(with: credential) as well :)

let credential = PhoneAuthProvider.provider().credential(withVerificationID: verificationID.value, verificationCode: code.value) Auth.auth().signInAndRetrieveData(with: credential)

arnauddorgans commented 5 years ago

You already have it with:

Auth.auth().rx.signInAndRetrieveData(with: crediential)

shvetsjr commented 5 years ago

Awesome! Sorry, didn't see it. I will close the issues now 👍

shvetsjr commented 5 years ago

I did update pods but I could not see any changes even tho I see it in develop :( @arnauddorgans

arnauddorgans commented 5 years ago

Sorry dude I totally forgot to push the release, you can update right now @ShvetsJr