search

RxSwiftCommunity / RxFlow

RxFlow is a navigation framework for iOS applications based on a Reactive Flow Coordinator pattern
MIT License
1.88k stars 118 forks source link

Reentrancy anomaly on .forwardToCurrentFlow #175

Closed erginbilgin closed 3 years ago

erginbilgin commented 3 years ago

Using .forwardToCurrentFlow(withStep:) causes a reentrancy anomaly. It is observable on demo project as well, right after SettingsFlow:93 (Run demo app and tap on settings button).

erginbilgin commented 3 years ago

@twittemb Are you still maintaining the project?

twittemb commented 3 years ago

@erginbilgin Hi, thanks for reaching. I'm still maintaining the project, I was on vacation with no computer ☺️. I will check this issue ASAP.

twittemb commented 3 years ago

Hey @erginbilgin, could you give it another try on the branch feature/bump-deps (please perform a Carthage bootstrap because the deps have been bumped)

thanks.

erginbilgin commented 3 years ago

@twittemb I will do at the first opportunity I find. 👍 Did you have a chance to check the other issue which I opened? https://github.com/RxSwiftCommunity/RxFlow/issues/176

twittemb commented 3 years ago

@erginbilgin can you try the new 2.12.4 release please ?

erginbilgin commented 3 years ago

It is not available yet in CocoaPods as I see. Will you push there soon?

twittemb commented 3 years ago

@erginbilgin

I've just released it :-)

erginbilgin commented 3 years ago

@twittemb Sorry for delay. Just tested it and warnings are gone. Seems like https://github.com/RxSwiftCommunity/RxFlow/issues/176 is solved too. Amazing. Thanks! :)

twittemb commented 3 years ago

Hey @erginbilgin

Happy to hear that.

Feel free to close the issues if you think they are resolved.

Bye.