fix : doesn't not apply allowsStepWhenDismissed property of new stepper - Githubissues

RxSwiftCommunity / RxFlow

RxFlow is a navigation framework for iOS applications based on a Reactive Flow Coordinator pattern

MIT License

1.88k stars 117 forks source link

fix : doesn't not apply allowsStepWhenDismissed property of new stepper #180

Closed HaeSeongPark closed 3 years ago

HaeSeongPark commented 3 years ago

Description

When I run DemoApp, I found a bug which is UISplitViewController detailVC's steps doesn't no be handled properly after first appear

Reproduce
1. Login Screen appear after tap setting icon button,
2. Then tap proceed button
3. But nothing happend

https://user-images.githubusercontent.com/24935280/138263572-7657022a-876c-4e3e-9111-9b70083de283.mov

I think main reason of this bug is that that doesn't not apply allowsStepWhenDismissed property of new stepper. So I modify it. Also demo code.

Result

https://user-images.githubusercontent.com/24935280/138264551-91757453-06e8-4c84-8513-442f85da1389.mov

Checklist

[x] this PR is based on develop or a 'develop related' branch
[x] the commits inside this PR have explicit commit messages
[x] the Jazzy documentation has been generated (if needed -> Jazzy RxFlow)