search

RxSwiftCommunity / RxKeyboard

Reactive Keyboard in iOS
MIT License
1.6k stars 176 forks source link

Swift4.1 support #61

Closed noppefoxwolf closed 6 years ago

noppefoxwolf commented 6 years ago

I builded latest commit.

swift 4.1 (902.0.48) https://github.com/noppefoxwolf/RxKeyboard/releases

Aurazion commented 6 years ago

Thanks for the fork. I hope the developer release his own build.

freak4pc commented 6 years ago

@noppefoxwolf Pushing your changes as a PR would be much more beneficial than building a separate fork :)

noppefoxwolf commented 6 years ago

I have no changes. I just compiled latest commit with swift4.1. So I'm couldn't send PR. Maybe @devxoul publish release build more better.

freak4pc commented 6 years ago

Oh I understand what you're saying :) OK.

mendesbarreto commented 6 years ago

Hey @freak4pc, what do you think of my PR, worth it?

freak4pc commented 6 years ago

Hey @mendesbarreto - No need to ping individual contributors :) When one of the contributors have time they usually review PRs. Also, since this is sort of @devxoul's library, I prefer him to review #62 .

freak4pc commented 6 years ago

Fixed in #62