search

RxSwiftCommunity / RxKeyboard

Reactive Keyboard in iOS
MIT License
1.6k stars 176 forks source link

Add Support to Swift 4.1 #62

Closed mendesbarreto closed 6 years ago

mendesbarreto commented 6 years ago

Closes issue #61

ThomasLeblond commented 6 years ago

Please can you merge the pull request.

freak4pc commented 6 years ago

Hey @ThomasLeblond. I'm gonna give the original author of the repo a chance by tomorrow and merge otherwise.

cc/ @devxoul

devxoul commented 6 years ago

Hey folks, sorry for delay. I had very busy days recently. I left a single comment and would be glad if you can review it.

PS: I really appreciate to @freak4pc to follow-up these issues :pray:

mendesbarreto commented 6 years ago

@freak4pc Sorry for the junk generated on my commits, but I really tried to be transparent with the work and maybe the single commits of each work I have done was a overkill 😞 .

If you have some post ou blog to indicate to me read and improve this skill and make the next contribution better, I will be really glad to you.

freak4pc commented 6 years ago

Sorry, didn’t mean junk as any relation to your work! I just meant that since there are so few changes to files in the sum of things, we can Squash (on our side) this entire PR as a single commit.

Really no worries and thanks for your contribution !

rxswiftcommunity[bot] commented 6 years ago

Thanks a lot for contributing @mendesbarreto! I've invited you to join the RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like more information on what this means, check out our contributor guidelines and feel free to reach out with any questions.

Generated by :no_entry_sign: dangerJS

devxoul commented 6 years ago

Thanks for your work, I've released 0.8.2 :tada:

ThomasLeblond commented 6 years ago

Thanks guys, this is very helpful for us :)