search

RxSwiftCommunity / RxKeyboard

Reactive Keyboard in iOS
MIT License
1.6k stars 176 forks source link

[Proposal] Abolition of provision of binary #71

Closed noppefoxwolf closed 5 years ago

noppefoxwolf commented 6 years ago

Providing binary will certainly speed up the installation. However, we need to wait for binary to be provided each time.

https://github.com/RxSwiftCommunity/RxKeyboard/issues/68 https://github.com/RxSwiftCommunity/RxKeyboard/issues/66

When Swift 5 is released, ABI solves this problem. Until then, I think that it is better not to provide the binary but to build it on each machine.

like this PR https://github.com/RxSwiftCommunity/RxKeyboard/pull/43

freak4pc commented 5 years ago

I think the value of using a binary is too great to entirely get rid of. (highly speeds up build time if the consumer is using whatever version of Swift that is) In essence, if the binary is invalid, you will get a re-compilation anyways - so I'm not sure why bother with abolition, as you suggest.

Here's an example:

***  Skipped installing realm-cocoa.framework binary due to the error:
    "Incompatible Swift version - framework was built with 4.1.2 (swiftlang-902.0.54 clang-902.0.39.2) and the local version is 4.2 (swiftlang-1000.11.37.1 clang-1000.11.45.1)."
    Falling back to building from the source
freak4pc commented 5 years ago

Closing for now. If you have additional questions, please let me know and I'll reopen.