search

RxSwiftCommunity / RxKeyboard

Reactive Keyboard in iOS
MIT License
1.6k stars 175 forks source link

Make compatible with RxSwift 4.4.0 and Xcode 10.1 #82

Closed RafaelPlantard closed 5 years ago

RafaelPlantard commented 5 years ago

Can anyone review it? @RxSwiftCommunity/contributors

freak4pc commented 5 years ago

I'm a bit confused - If someone is using RxSwift 4.4.0, they would have no problem using this. There isn't really a compatibility issue that I see. Did you experience any issue here?

RafaelPlantard commented 5 years ago

@freak4pc my real problem is that I'm using Carthage and the latest version of RxKeyboard was compiled with Swift 4.1.2, and Xcode 10.1 version of swift is 4.2

freak4pc commented 5 years ago

Oh, it's a Carthage thing. Yeah, that one's tricky :) Merging this won't be enough, we'll need to make a new binary, etc.

RafaelPlantard commented 5 years ago

For while I forked this project and using deploy code on travis.yml, I generate a new zip artifact

AlexisQapa commented 5 years ago

Can this be merged and a new binary built so we can use Carthage the easy way ?

freak4pc commented 5 years ago

I think this is solved in #81