search

RxSwiftCommunity / RxKeyboard

Reactive Keyboard in iOS
MIT License
1.6k stars 175 forks source link

Fix compilation and memory leak errors in readme.md #85

Closed M0rtyMerr closed 5 years ago

M0rtyMerr commented 5 years ago

I understand that this code is provided just to "show the concept". But i don't think it's rational argument to give user incorrect code with memory leak. Imagine someone copy-pasted it and get leaked viewController.

I didn't add guard let 'self' = self else { return } to keep code short.

freak4pc commented 5 years ago

I agree with @twittemb's comment - left a single example, feel free to make the rest :)

M0rtyMerr commented 5 years ago

@twittemb thank u for review. Please check new changes.

M0rtyMerr commented 5 years ago

@freak4pc , @twittemb please gents, let's approve that, i think it's kind of important PR.

freak4pc commented 5 years ago

Hey @MortyMerr. Please be patient, we're volunteers, not employees. It's only been 3 days :)

"Important" might be exaggerated since its just a documentation page, there's no critical bug or anything in the code itself.

M0rtyMerr commented 5 years ago

Hey @freak4pc . Sorry, didn't want to be rude. Thank u for ur work) Agree with u, but actually documentation page is the face of the repo. I would disrespect any project for buggy code in docs.